Silence "end of non-void function" warnings with llvm_unreachable and add an assert.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@139474 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Analysis/ThreadSafety.cpp b/lib/Analysis/ThreadSafety.cpp
index b7d94db105699e879dec17d3addaff1a710c54c6..297928dd97ccbe1d67ee67e2448ae3f549526f3d 100644 (file)
--- a/lib/Analysis/ThreadSafety.cpp
+++ b/lib/Analysis/ThreadSafety.cpp
@@ -300,6 +300,7 @@ class BuildLockset : public StmtVisitor<BuildLockset> {
       case LK_Exclusive:
         return locksetContains(Lock, KindRequested);
     }
+    llvm_unreachable("Unknown LockKind");
   }
 
 public:
@@ -805,5 +806,6 @@ LockKind getLockKindFromAccessKind(AccessKind AK) {
     case AK_Written :
       return LK_Exclusive;
   }
+  llvm_unreachable("Unknown AccessKind");
 }
 }} // end namespace clang::thread_safety

diff --git a/lib/Sema/SemaOverload.cpp b/lib/Sema/SemaOverload.cpp
index c200daedfbb35523380219677ed57fcf3ee034bb..cce4057dd74db122101efb7f7abb78e983a34498 100644 (file)
--- a/lib/Sema/SemaOverload.cpp
+++ b/lib/Sema/SemaOverload.cpp
@@ -7288,10 +7288,12 @@ SourceLocation GetLocationForCandidate(const OverloadCandidate *Cand) {
   return SourceLocation();
 }
 
-static unsigned RankDeductionFailure(
-    const OverloadCandidate::DeductionFailureInfo &DFI) {
+static unsigned
+RankDeductionFailure(const OverloadCandidate::DeductionFailureInfo &DFI) {
   switch ((Sema::TemplateDeductionResult)DFI.Result) {
   case Sema::TDK_Success:
+    assert(0 && "TDK_success while diagnosing bad deduction");
+
   case Sema::TDK_Incomplete:
     return 1;
 
@@ -7314,6 +7316,7 @@ static unsigned RankDeductionFailure(
   case Sema::TDK_TooFewArguments:
     return 6;
   }
+  llvm_unreachable("Unhandled deduction result");
 }
 
 struct CompareOverloadCandidatesForDisplay {