PyFloat_FromString(): Conversion of sprintf() to PyOS_snprintf() for

buffer overrun avoidance.

diff --git a/Objects/floatobject.c b/Objects/floatobject.c
index cdc9620c0204c21ea6227af57ce520175a54ddaa..02a1e1aa57e98fe01e2f846d784b2dd82ca14edb 100644 (file)
--- a/Objects/floatobject.c
+++ b/Objects/floatobject.c
@@ -150,7 +150,8 @@ PyFloat_FromString(PyObject *v, char **pend)
        if (end > last)
                end = last;
        if (end == s) {
-               sprintf(buffer, "invalid literal for float(): %.200s", s);
+               PyOS_snprintf(buffer, sizeof(buffer),
+                             "invalid literal for float(): %.200s", s);
                PyErr_SetString(PyExc_ValueError, buffer);
                return NULL;
        }
@@ -159,7 +160,8 @@ PyFloat_FromString(PyObject *v, char **pend)
        while (*end && isspace(Py_CHARMASK(*end)))
                end++;
        if (*end != '\0') {
-               sprintf(buffer, "invalid literal for float(): %.200s", s);
+               PyOS_snprintf(buffer, sizeof(buffer),
+                             "invalid literal for float(): %.200s", s);
                PyErr_SetString(PyExc_ValueError, buffer);
                return NULL;
        }