Fix undefined behaviour in _postgis_gserialized_stats

References #4466

git-svn-id: http://svn.osgeo.org/postgis/branches/2.3@17632 b70326c6-7e19-0410-871a-916f4a2858ee

diff --git a/NEWS b/NEWS
index c485a04b4a8f91d5cb4fd4d766a71cf8242a387c..6ede78aa532ad27e65bdb412729fbe6d504b8236 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,7 @@ PostGIS 2.3.10
   - #4388, AddRasterConstraints: Ignore NULLs when generating constraints (Raúl Marín)
   - #4327, Avoid pfree'ing the result of getenv (Raúl Marín)
   - #4406, Throw on invalid characters when decoding geohash (Raúl Marín)
+  - #4466, Fix undefined behaviour in _postgis_gserialized_stats (Raúl Marín)
 
 
 PostGIS 2.3.9

diff --git a/postgis/gserialized_estimate.c b/postgis/gserialized_estimate.c
index 9168c9ff0562e9b86fa6ddbe62f94716f3b81b8d..741ed4a1553a5e08ae333f0fe3c2831e2915c6eb 100644 (file)
--- a/postgis/gserialized_estimate.c
+++ b/postgis/gserialized_estimate.c
@@ -2002,10 +2002,6 @@ Datum _postgis_gserialized_stats(PG_FUNCTION_ARGS)
        if ( ! PG_ARGISNULL(2) )
                mode = text_p_get_mode(PG_GETARG_TEXT_P(2));
 
-       /* Check if we've been asked to only use stats from parent */
-       if ( ! PG_ARGISNULL(3) )
-               only_parent = PG_GETARG_BOOL(3);
-
        /* Retrieve the stats object */
        nd_stats = pg_get_nd_stats_by_name(table_oid, att_text, mode, only_parent);
        if ( ! nd_stats )