On overflow, warn before freeing anything.

diff --git a/plugins/sudoers/ldap.c b/plugins/sudoers/ldap.c
index be074ca907a61fb91f87981107a6f4a49ccd4dcd..b1c2000ff85c2a771d29ee5ac07b657c343905c9 100644 (file)
--- a/plugins/sudoers/ldap.c
+++ b/plugins/sudoers/ldap.c
@@ -1361,8 +1361,8 @@ oom:
        ldap_msgfree(result);
     debug_return_bool(false);
 overflow:
-    free(filt);
     sudo_warnx(U_("internal error, %s overflow"), __func__);
+    free(filt);
     debug_return_bool(false);
 }
 
@@ -1533,8 +1533,8 @@ oom:
     ldap_msgfree(result);
     debug_return_bool(false);
 overflow:
-    free(filt);
     sudo_warnx(U_("internal error, %s overflow"), __func__);
+    free(filt);
     debug_return_bool(false);
 }
 
@@ -1689,8 +1689,8 @@ sudo_ldap_build_pass1(LDAP *ld, struct passwd *pw)
 
     debug_return_str(buf);
 overflow:
-    free(buf);
     sudo_warnx(U_("internal error, %s overflow"), __func__);
+    free(buf);
     debug_return_str(NULL);
 }