]> granicus.if.org Git - postgresql/commitdiff
Fix broken pg_dump code for dumping comments on event triggers.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 6 Jan 2015 00:27:04 +0000 (19:27 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 6 Jan 2015 00:27:04 +0000 (19:27 -0500)
This never worked, I think.  Per report from Marc Munro.

In passing, fix funny spacing in the COMMENT ON command as a result of
excess space in the "label" string.

src/bin/pg_dump/pg_dump.c

index 6658fda83e3ea9dc4e3bcc2d2517aefbafd19b03..fc7a9ec9dba82e9bbb8da2b5d80f3cfcfdb44f89 100644 (file)
@@ -15097,7 +15097,7 @@ dumpEventTrigger(Archive *fout, DumpOptions *dopt, EventTriggerInfo *evtinfo)
                }
                appendPQExpBufferStr(query, ";\n");
        }
-       appendPQExpBuffer(labelq, "EVENT TRIGGER %s ",
+       appendPQExpBuffer(labelq, "EVENT TRIGGER %s",
                                          fmtId(evtinfo->dobj.name));
 
        ArchiveEntry(fout, evtinfo->dobj.catId, evtinfo->dobj.dumpId,
@@ -15106,7 +15106,7 @@ dumpEventTrigger(Archive *fout, DumpOptions *dopt, EventTriggerInfo *evtinfo)
                                 query->data, "", NULL, NULL, 0, NULL, NULL);
 
        dumpComment(fout, dopt, labelq->data,
-                               NULL, NULL,
+                               NULL, evtinfo->evtowner,
                                evtinfo->dobj.catId, 0, evtinfo->dobj.dumpId);
 
        destroyPQExpBuffer(query);