issue_warnings() has no business freeing its parameter, especially not when

its sole caller does that too.  Jan Matousek, via Pavel Stehule

diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c
index 31f12fbab2c37b1ebab9824a57e334219fe390b1..f989229f86a905d6b18b386a12d0b0c6948e4e56 100644 (file)
--- a/contrib/pg_upgrade/check.c
+++ b/contrib/pg_upgrade/check.c
@@ -154,7 +154,6 @@ issue_warnings(migratorContext *ctx, char *sequence_script_file_name)
                                          ctx->new.bindir, ctx->new.port, sequence_script_file_name,
                                          ctx->logfile);
                        unlink(sequence_script_file_name);
-                       pg_free(sequence_script_file_name);
                        check_ok(ctx);
                }