]> granicus.if.org Git - php/commitdiff
Fixed Bug #60173 (Wrong error message on reflective trait instantiation)
authorStefan Marr <gron@php.net>
Mon, 31 Oct 2011 22:59:00 +0000 (22:59 +0000)
committerStefan Marr <gron@php.net>
Mon, 31 Oct 2011 22:59:00 +0000 (22:59 +0000)
Zend/tests/traits/bug60173.phpt [new file with mode: 0644]
Zend/zend_API.c

diff --git a/Zend/tests/traits/bug60173.phpt b/Zend/tests/traits/bug60173.phpt
new file mode 100644 (file)
index 0000000..a28a103
--- /dev/null
@@ -0,0 +1,12 @@
+--TEST--
+Bug #60173 (Wrong error message on reflective trait instantiation)
+--FILE--
+<?php
+
+trait foo { }
+
+$rc = new ReflectionClass('foo');
+$rc->newInstance();
+
+--EXPECTF--
+Fatal error: Cannot instantiate trait foo in %s on line %d
index ed2f6d6e38562f95b43b5a3b65fac0890e76421c..95afc13d9c2ccf50e7e5ed8e0ec63369714515b4 100644 (file)
@@ -1107,7 +1107,9 @@ ZEND_API int _object_and_properties_init(zval *arg, zend_class_entry *class_type
        zend_object *object;
 
        if (class_type->ce_flags & (ZEND_ACC_INTERFACE|ZEND_ACC_IMPLICIT_ABSTRACT_CLASS|ZEND_ACC_EXPLICIT_ABSTRACT_CLASS)) {
-               char *what = class_type->ce_flags & ZEND_ACC_INTERFACE ? "interface" : "abstract class";
+               char *what =   (class_type->ce_flags & ZEND_ACC_INTERFACE)                ? "interface"
+                                        :((class_type->ce_flags & ZEND_ACC_TRAIT) == ZEND_ACC_TRAIT) ? "trait"
+                                        :                                                              "abstract class";
                zend_error(E_ERROR, "Cannot instantiate %s %s", what, class_type->name);
        }