Tolerate EINVAL when calling fsync() on a directory.

Previously, we tolerated EBADF as a way for the operating system to
indicate that it doesn't support fsync() on a directory.  Tolerate
EINVAL too, for older versions of Linux CIFS.

Bug #15636.  Back-patch all the way.

Reported-by: John Klann
Discussion: https://postgr.es/m/15636-d380890dafd78fc6@postgresql.org

diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
index 757aa083a0c7ab346d0f56b5682a713db905c4c3..6d016a79e93679b85b6d6191425036a7b5a62b45 100644 (file)
--- a/src/backend/storage/file/fd.c
+++ b/src/backend/storage/file/fd.c
@@ -3167,7 +3167,7 @@ fsync_fname_ext(const char *fname, bool isdir, bool ignore_perm, int elevel)
         * Some OSes don't allow us to fsync directories at all, so we can ignore
         * those errors. Anything else needs to be logged.
         */
-       if (returncode != 0 && !(isdir && errno == EBADF))
+       if (returncode != 0 && !(isdir && (errno == EBADF || errno == EINVAL)))
        {
                int                     save_errno;
 

diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
index d303ebb98b5edc24d4fc504e3499679da605bae9..dba438f782a29a26c42b938f4ef1a5e0940a1cf9 100644 (file)
--- a/src/bin/initdb/initdb.c
+++ b/src/bin/initdb/initdb.c
@@ -699,7 +699,7 @@ fsync_fname_ext(const char *fname, bool isdir)
         * Some OSes don't allow us to fsync directories at all, so we can ignore
         * those errors. Anything else needs to be reported.
         */
-       if (returncode != 0 && !(isdir && errno == EBADF))
+       if (returncode != 0 && !(isdir && (errno == EBADF || errno == EINVAL)))
                fprintf(stderr, _("%s: could not fsync file \"%s\": %s\n"),
                                progname, fname, strerror(errno));