]> granicus.if.org Git - postgresql/commitdiff
Remove pgbench "progress" test pending solution of its timing issues.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 23 Sep 2017 17:02:30 +0000 (13:02 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 23 Sep 2017 17:02:30 +0000 (13:02 -0400)
Buildfarm member skink shows that this is even more flaky than
I thought.  There are probably some actual pgbench bugs here
as well as a timing dependency.  But we can't have stuff this
unstable in the buildfarm, it obscures other issues.

src/bin/pgbench/t/001_pgbench_with_server.pl

index 7db4bc8c978a9e80963703ba20f625ca6057c6cd..11bc0fecfefcb18d94a26fad02b4f5a6f7ae0d9e 100644 (file)
@@ -445,28 +445,6 @@ sub check_pgbench_logs
        ok(unlink(@logs), "remove log files");
 }
 
-# note: --progress-timestamp is not tested
-pgbench(
-       '-T 2 -P 1 -l --log-prefix=001_pgbench_log_1 --aggregate-interval=1'
-         . ' -S -b se@2 --rate=20 --latency-limit=1000 -j ' . $nthreads
-         . ' -c 3 -r',
-       0,
-       [   qr{type: multiple},
-               qr{clients: 3},
-               qr{threads: $nthreads},
-               qr{duration: 2 s},
-               qr{script 1: .* select only},
-               qr{script 2: .* select only},
-               qr{statement latencies in milliseconds},
-               qr{FROM pgbench_accounts} ],
-       [ qr{vacuum}, qr{progress: 1\b} ],
-       'pgbench progress');
-
-# $nthreads threads, 2 seconds, but due to timing imprecision we might get
-# only 1 or as many as 3 progress reports per thread.
-check_pgbench_logs('001_pgbench_log_1', $nthreads, 1, 3,
-       qr{^\d+ \d{1,2} \d+ \d+ \d+ \d+ \d+ \d+ \d+ \d+ \d+$});
-
 # with sampling rate
 pgbench(
 '-n -S -t 50 -c 2 --log --log-prefix=001_pgbench_log_2 --sampling-rate=0.5',