Fix possible failure to mark hash metapage dirty.

Report and suggested fix by Lixian Zou.  Amit Kapila put it
in the form of a patch and reviewed.

Discussion: http://postgr.es/m/151739848647.1239.12528851873396651946@wrigleys.postgresql.org

diff --git a/src/backend/access/hash/hashovfl.c b/src/backend/access/hash/hashovfl.c
index c9de1283dca213ff50aecfb42a1473220aba9e2f..2033b2f7f975ac6a0868a08118ec18ea559c8f69 100644 (file)
--- a/src/backend/access/hash/hashovfl.c
+++ b/src/backend/access/hash/hashovfl.c
@@ -341,9 +341,10 @@ found:
                        metap->hashm_mapp[metap->hashm_nmaps] = BufferGetBlockNumber(newmapbuf);
                        metap->hashm_nmaps++;
                        metap->hashm_spares[splitnum]++;
-                       MarkBufferDirty(metabuf);
                }
 
+               MarkBufferDirty(metabuf);
+
                /*
                 * for new overflow page, we don't need to explicitly set the bit in
                 * bitmap page, as by default that will be set to "in use".