]> granicus.if.org Git - php/commitdiff
Kill an unnecessary bit of internal docu and add 'compression' to the TODO
authorSteph Fox <sfox@php.net>
Thu, 28 Feb 2008 02:09:49 +0000 (02:09 +0000)
committerSteph Fox <sfox@php.net>
Thu, 28 Feb 2008 02:09:49 +0000 (02:09 +0000)
ext/phar/TODO
ext/phar/phar_object.c

index d157f7ec8c1266323e576d046706ddef48bc4628..96d26466b9357d61d81d27f93d7324e240ce0770 100644 (file)
@@ -96,6 +96,7 @@ Version 2.0.0
  * prevent manual addition of stub via $a['.phar/stub.php'] = '<?php my stub';
  * investigate potential collision between SPL's DirectoryIterator flags and
    those in phar_archive_data
+ * compression should work for non-phar archives
  X implement initial support for simple zip/tar archives (PharData) [Steph]
  X make createDefaultStub() setDefaultStub() and have it file format-specific
    [Steph]
index a306984d319cab41713dac731e8b3da43c8cb9fd..59229c98d90471bf776482fa37d5d95feaecfaba 100755 (executable)
@@ -1821,7 +1821,6 @@ PHP_METHOD(Phar, convertToZip)
                return;
        }
 
-// need to check that the string isn't Phar::GZ etc
        if (ext_len) {
                if (strncmp(ext, "Phar::GZ", 8) || strncmp(ext, "Phar::BZ2", 9)) {
                        zend_throw_exception_ex(spl_ce_UnexpectedValueException, 0 TSRMLS_CC,