]> granicus.if.org Git - python/commitdiff
Cleanup: move code out of a try block
authorÉric Araujo <merwok@netwok.org>
Mon, 29 Aug 2011 22:45:59 +0000 (00:45 +0200)
committerÉric Araujo <merwok@netwok.org>
Mon, 29 Aug 2011 22:45:59 +0000 (00:45 +0200)
Lib/packaging/command/__init__.py

index 6a3785061b9dc0b99f66c47d4060da46fa96e7e7..2b52190b01370531ff5a6321cc9487210704e2e2 100644 (file)
@@ -30,6 +30,8 @@ _COMMANDS = {
     'upload': 'packaging.command.upload.upload',
     'upload_docs': 'packaging.command.upload_docs.upload_docs'}
 
+# XXX use OrderedDict to preserve the grouping (build-related, install-related,
+# distribution-related)
 STANDARD_COMMANDS = set(_COMMANDS)
 
 
@@ -48,9 +50,9 @@ def get_command_class(name):
     """Return the registered command"""
     try:
         cls = _COMMANDS[name]
-        if isinstance(cls, str):
-            cls = resolve_name(cls)
-            _COMMANDS[name] = cls
-        return cls
     except KeyError:
         raise PackagingModuleError("Invalid command %s" % name)
+    if isinstance(cls, str):
+        cls = resolve_name(cls)
+        _COMMANDS[name] = cls
+    return cls