bpo-24567: Random subnormal.diff (GH-7954) (GH-7956)

Handle subnormal weights for choices()
(cherry picked from commit ddf7171911e117aa7ad4b0f9ded4f0c3a4ca0fec)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>

diff --git a/Lib/random.py b/Lib/random.py
index 7a2585e01ab3a36f154301dc36fb00809280169f..61e881642cb3f446e0291668c4a7d4294dceba06 100644 (file)
--- a/Lib/random.py
+++ b/Lib/random.py
@@ -360,7 +360,9 @@ class Random(_random.Random):
             raise ValueError('The number of weights does not match the population')
         bisect = _bisect.bisect
         total = cum_weights[-1]
-        return [population[bisect(cum_weights, random() * total)] for i in range(k)]
+        hi = len(cum_weights) - 1
+        return [population[bisect(cum_weights, random() * total, 0, hi)]
+                for i in range(k)]
 
 ## -------------------- real-valued distributions  -------------------
 

diff --git a/Lib/test/test_random.py b/Lib/test/test_random.py
index 10f431a63eb75b365dacc4c135f2d50dc2b15b13..877adf1ced4029e51638cf01467ebc405c33c717 100644 (file)
--- a/Lib/test/test_random.py
+++ b/Lib/test/test_random.py
@@ -220,6 +220,14 @@ class TestBasicOps:
         with self.assertRaises(IndexError):
             choices([], cum_weights=[], k=5)
 
+    def test_choices_subnormal(self):
+        # Subnormal weights would occassionally trigger an IndexError
+        # in choices() when the value returned by random() was large
+        # enough to make `random() * total` round up to the total.
+        # See https://bugs.python.org/msg275594 for more detail.
+        choices = self.gen.choices
+        choices(population=[1, 2], weights=[1e-323, 1e-323], k=5000)
+
     def test_gauss(self):
         # Ensure that the seed() method initializes all the hidden state.  In
         # particular, through 2.2.1 it failed to reset a piece of state used

diff --git a/Misc/NEWS.d/next/Library/2018-06-27-00-31-30.bpo-24567.FuePyY.rst b/Misc/NEWS.d/next/Library/2018-06-27-00-31-30.bpo-24567.FuePyY.rst
new file mode 100644 (file)
index 0000000..d496f2b
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2018-06-27-00-31-30.bpo-24567.FuePyY.rst
@@ -0,0 +1,2 @@
+Improve random.choices() to handle subnormal input weights that could
+occasionally trigger an IndexError.