]> granicus.if.org Git - python/commitdiff
Merged revisions 76588 via svnmerge from
authorTarek Ziadé <ziade.tarek@gmail.com>
Sun, 29 Nov 2009 22:24:57 +0000 (22:24 +0000)
committerTarek Ziadé <ziade.tarek@gmail.com>
Sun, 29 Nov 2009 22:24:57 +0000 (22:24 +0000)
svn+ssh://pythondev@svn.python.org/python/trunk

........
  r76588 | tarek.ziade | 2009-11-29 23:20:30 +0100 (Sun, 29 Nov 2009) | 1 line

  Fixed #7408: dropped group ownership checking because it relies on os-specific rules
........

Lib/distutils/tests/test_sdist.py
Misc/NEWS

index c10e973ed73cab25868589daa5f084fbac9783c9..e0f1e93768f504b40e18ebbfbd43b4e8f2d15b93 100644 (file)
@@ -336,10 +336,13 @@ class SDistTestCase(PyPIRCCommandTestCase):
         # making sure we have the good rights
         archive_name = join(self.tmp_dir, 'dist', 'fake-1.0.tar.gz')
         archive = tarfile.open(archive_name)
+
+        # note that we are not testing the group ownership here
+        # because, depending on the platforms and the container
+        # rights (see #7408)
         try:
             for member in archive.getmembers():
                 self.assertEquals(member.uid, os.getuid())
-                self.assertEquals(member.gid, os.getgid())
         finally:
             archive.close()
 
index 4efc4790745396b5a55e2b1144ae847d0bf7390e..96fbbce89df312986f7f801b14c84d139a34c084 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -140,6 +140,10 @@ C-API
 Library
 -------
 
+- Issue #7408: Fixed distutils.tests.sdist so it doesn't check for group
+  ownership when the group is not forced, because the group may be different
+  from the user's group and inherit from its container when the test is run.
+
 - Issue #4486: When an exception has an explicit cause, do not print its
   implicit context too.  This affects the `traceback` module as well as
   built-in exception printing.