smyrna: fix 'readlink' compilation error on macOS

The code added in 24bd92c1e5d49b354141cd06d88ca658991b9825 calls `readlink` in
multiple paths, including the macOS branch. This function needs the #include
<unistd.h> but we were only conditionally including it when not on Windows or
macOS, when we _do_ need it on macOS. Similar to the previous commit, it seems
this went unnoticed because the macOS CI jobs do not build Smyrna.

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e12c24ebce0220ece9e889a32493471819664a11..c6e5136172cf302a34b333ba17bba5ce31d7d731 100644 (file)
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -24,6 +24,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Do not try to install `gv.php` if using SWIG-4.1.0. Graphviz 7.0.1 changes
   listed SWIG 4.1.0 as supported, but there was an oversight that is fixed in
   7.0.2. Complete #2277, #2303
+- Several compilation errors when building Smyrna on macOS have been fixed. This
+  was a regression in Graphviz 7.0.1.
 
 ## [7.0.1] – 2022-11-09
 

diff --git a/cmd/smyrna/main.c b/cmd/smyrna/main.c
index 61223a93bbe8c7872380657b5e563eed8380573b..3edf9ab1d8d501c1068f40b50207f180ce2318c4 100644 (file)
--- a/cmd/smyrna/main.c
+++ b/cmd/smyrna/main.c
@@ -50,7 +50,7 @@
 #include <sys/types.h>
 #endif
 
-#if !defined(__APPLE__) && !defined(_WIN32)
+#if !defined(_WIN32)
 #include <unistd.h>
 #endif