Fix overflow in extract(epoch from interval) for intervals exceeding 68 years.
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 16 Sep 2007 15:56:39 +0000 (15:56 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 16 Sep 2007 15:56:39 +0000 (15:56 +0000)
Seems to have been introduced in 8.1 by careless SECS_PER_DAY
search-and-replace.

src/backend/utils/adt/timestamp.c

index 2cf4f5878b912dbec5c71628e5c7768a6192b963..b00caeee93c256ff73481a284990c4a7eab79faf 100644 (file)
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/utils/adt/timestamp.c,v 1.157.2.1 2005/11/22 18:23:22 momjian Exp $
+ *       $PostgreSQL: pgsql/src/backend/utils/adt/timestamp.c,v 1.157.2.2 2007/09/16 15:56:39 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -3979,9 +3979,9 @@ interval_part(PG_FUNCTION_ARGS)
 #else
                result = interval->time;
 #endif
-               result += (DAYS_PER_YEAR * SECS_PER_DAY) * (interval->month / MONTHS_PER_YEAR);
+               result += ((double) DAYS_PER_YEAR * SECS_PER_DAY) * (interval->month / MONTHS_PER_YEAR);
                result += ((double) DAYS_PER_MONTH * SECS_PER_DAY) * (interval->month % MONTHS_PER_YEAR);
-               result += interval->day * SECS_PER_DAY;
+               result += ((double) SECS_PER_DAY) * interval->day;
        }
        else
        {