Address review feedbacks of AddDiscriminator change

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@272850 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/llvm/Transforms/Utils/AddDiscriminators.h b/include/llvm/Transforms/Utils/AddDiscriminators.h
index 6096d21cb019bf813b89bc1f3ed6bcd1e533a4c9..0b3a8add6278b5b3f8bbdfa7550af2985b1c853c 100644 (file)
--- a/include/llvm/Transforms/Utils/AddDiscriminators.h
+++ b/include/llvm/Transforms/Utils/AddDiscriminators.h
@@ -20,11 +20,10 @@
 
 namespace llvm {
 
-/// Converts loops into loop-closed SSA form.
 class AddDiscriminatorsPass : public PassInfoMixin<AddDiscriminatorsPass> {
 public:
   PreservedAnalyses run(Function &F, AnalysisManager<Function> &AM);
 };
 } // end namespace llvm
 
-#endif // LLVM_TRANSFORMS_UTILS_LCSSA_H
+#endif // LLVM_TRANSFORMS_UTILS_ADDDISCRIMINATORS_H

diff --git a/lib/Transforms/Utils/AddDiscriminators.cpp b/lib/Transforms/Utils/AddDiscriminators.cpp
index baf65b628b686fc0fd6ff85612fd1f5c6f4e1626..d034905b6572b25f6c2713aa3fab7cc3db486d2e 100644 (file)
--- a/lib/Transforms/Utils/AddDiscriminators.cpp
+++ b/lib/Transforms/Utils/AddDiscriminators.cpp
@@ -155,7 +155,7 @@ FunctionPass *llvm::createAddDiscriminatorsPass() {
 /// lexical block for I2 and all the instruction in B2 that share the same
 /// file and line location as I2. This new lexical block will have a
 /// different discriminator number than I1.
-bool addDiscriminators(Function &F) {
+static bool addDiscriminators(Function &F) {
   // If the function has debug information, but the user has disabled
   // discriminators, do nothing.
   // Simlarly, if the function has no debug info, do nothing.
@@ -250,7 +250,9 @@ bool AddDiscriminatorsLegacyPass::runOnFunction(Function &F) {
 }
 PreservedAnalyses AddDiscriminatorsPass::run(Function &F,
                                              AnalysisManager<Function> &AM) {
-  addDiscriminators(F);
-  // Only modifies debug info.
-  return PreservedAnalyses::all();
+  if (!addDiscriminators(F))
+    return PreservedAnalyses::all();
+
+  // FIXME: should be all()
+  return PreservedAnalyses::none();
 }