]> granicus.if.org Git - php/commitdiff
- Beware of signedness
authorMoriyoshi Koizumi <moriyoshi@php.net>
Mon, 18 Aug 2008 03:26:06 +0000 (03:26 +0000)
committerMoriyoshi Koizumi <moriyoshi@php.net>
Mon, 18 Aug 2008 03:26:06 +0000 (03:26 +0000)
ext/standard/html.c

index abc8347499d3b94f6b63de08e88875fc6b2fb9cf..2b0920722c39646890535ecb57042f3e59034cb5 100644 (file)
@@ -1201,21 +1201,21 @@ encode_amp:
                                                        if (*s == 'x' || *s == 'X') {
                                                                s++;
                                                                while (s < e) {
-                                                                       if (!isxdigit(*s++)) {
+                                                                       if (!isxdigit((int)*(unsigned char *)s++)) {
                                                                                goto encode_amp;
                                                                        }
                                                                }
                                                        /* Dec (&#90;)*/
                                                        } else {
                                                                while (s < e) {
-                                                                       if (!isdigit(*s++)) {
+                                                                       if (!isdigit((int)*(unsigned char *)s++)) {
                                                                                goto encode_amp;
                                                                        }
                                                                }
                                                        }
                                                } else { /* text entities */
                                                        while (s < e) {
-                                                               if (!isalnum(*s++)) {
+                                                               if (!isalnum((int)*(unsigned char *)s++)) {
                                                                        goto encode_amp;
                                                                }
                                                        }