]> granicus.if.org Git - python/commitdiff
Add comment that should be addressed
authorNeal Norwitz <nnorwitz@gmail.com>
Sun, 12 Aug 2007 17:21:38 +0000 (17:21 +0000)
committerNeal Norwitz <nnorwitz@gmail.com>
Sun, 12 Aug 2007 17:21:38 +0000 (17:21 +0000)
Objects/unicodeobject.c

index 6b27adb73c594d201f70367527950cdf938a1e4f..47109a5b3c6a318ab6fbd1eb698fb6f4dd8c7ae9 100644 (file)
@@ -1188,6 +1188,9 @@ PyObject *_PyUnicode_AsDefaultEncodedString(PyObject *unicode,
         return v;
     if (errors != NULL)
         Py_FatalError("non-NULL encoding in _PyUnicode_AsDefaultEncodedString");
+    /* XXX(nnorwitz): errors will always be NULL due to the check above.
+       Should this check and the else be removed since it's dead code?
+     */
     if (errors == NULL) {
         b = PyUnicode_EncodeUTF8(PyUnicode_AS_UNICODE(unicode),
                                  PyUnicode_GET_SIZE(unicode),