Unfix compiler warning. Compiler warnings good, BIC changes bad.

Make it a bit more obvious for the next poor fellow

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@706333 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

diff --git a/taglib/fileref.cpp b/taglib/fileref.cpp
index 0b0a49a31e697b87888b05895d5784031b3db088..afc197966a9f3564faa4a2caa6ea61752d03a5be 100644 (file)
--- a/taglib/fileref.cpp
+++ b/taglib/fileref.cpp
@@ -48,10 +48,6 @@ List<const FileRef::FileTypeResolver *> FileRef::FileRefPrivate::fileTypeResolve
 // public members
 ////////////////////////////////////////////////////////////////////////////////
 
-FileRef::FileTypeResolver::~FileTypeResolver()
-{
-}
-
 FileRef::FileRef()
 {
     d = new FileRefPrivate(0);

diff --git a/taglib/fileref.h b/taglib/fileref.h
index b4f1c46eaeba637fef07c0faf0b049b6583d239e..774d8f9016f9546a23ef1fe881503d76fb3c11b0 100644 (file)
--- a/taglib/fileref.h
+++ b/taglib/fileref.h
@@ -89,10 +89,9 @@ namespace TagLib {
     class FileTypeResolver
     {
     public:
-      /*!
-       * Destroys this FileTypeResolver instance.
-       */
-      virtual ~FileTypeResolver();
+      // do not fix compiler warning about missing virtual destructor
+      // since this would not be binary compatible
+      // let Scott fix it whenever he thinks BIC changes can next be applied
       /*!
        * This method must be overridden to provide an additional file type
        * resolver.  If the resolver is able to determine the file type it should

diff --git a/taglib/mpeg/id3v1/id3v1tag.cpp b/taglib/mpeg/id3v1/id3v1tag.cpp
index b336a48430860a277b87be7d0c8634feea19309e..f6fb501e597b2415cb848ec70a43e6dc19495445 100644 (file)
--- a/taglib/mpeg/id3v1/id3v1tag.cpp
+++ b/taglib/mpeg/id3v1/id3v1tag.cpp
@@ -53,10 +53,6 @@ const ID3v1::StringHandler *ID3v1::Tag::TagPrivate::stringHandler = new StringHa
 // StringHandler implementation
 ////////////////////////////////////////////////////////////////////////////////
 
-ID3v1::StringHandler::~StringHandler()
-{
-}
-
 String ID3v1::StringHandler::parse(const ByteVector &data) const
 {
   return String(data, String::Latin1).stripWhiteSpace();

diff --git a/taglib/mpeg/id3v1/id3v1tag.h b/taglib/mpeg/id3v1/id3v1tag.h
index baef325bd086bb5d6564560cc3e7333ecbfb37ba..a0ef6bb4e85459c8f5f96b1fe45a511ab9f6dca2 100644 (file)
--- a/taglib/mpeg/id3v1/id3v1tag.h
+++ b/taglib/mpeg/id3v1/id3v1tag.h
@@ -56,10 +56,12 @@ namespace TagLib {
     class StringHandler
     {
     public:
+      // do not fix compiler warning about missing virtual destructor
+      // since this would not be binary compatible
+      // let Scott fix it whenever he thinks BIC changes can next be applied
       /*!
        * Destroys this StringHandler instance.
        */
-      virtual ~StringHandler();
       /*!
        * Decode a string from \a data.  The default implementation assumes that
        * \a data is an ISO-8859-1 (Latin1) character array.