Ensure that BUFFER variables are initialized to prevent later attempts

to traverse an uninitialized pointer.

diff --git a/commands.c b/commands.c
index 68cfe276b2606d2399f63a1f4294b43ea2ae56a9..6b23e396c6562333dc6d5c6413fc953adb7b8910 100644 (file)
--- a/commands.c
+++ b/commands.c
@@ -617,6 +617,7 @@ void mutt_enter_command (void)
   buffer[0] = 0;
   if (mutt_get_field (":", buffer, sizeof (buffer), M_COMMAND) != 0 || !buffer[0])
     return;
+  mutt_buffer_init (&err);
   err.dsize = STRING;
   err.data = safe_malloc(err.dsize);
   mutt_buffer_init (&token);

diff --git a/hook.c b/hook.c
index 6e881ef54fb17c3d067ce798475dd980f881f776..34f310653b17004cb1b14255e775d901cff14ab2 100644 (file)
--- a/hook.c
+++ b/hook.c
@@ -281,7 +281,8 @@ void mutt_folder_hook (char *path)
   BUFFER err, token;
 
   current_hook_type = M_FOLDERHOOK;
-  
+
+  mutt_buffer_init (&err);
   err.dsize = STRING;
   err.data = safe_malloc (err.dsize);
   mutt_buffer_init (&token);
@@ -332,7 +333,8 @@ void mutt_message_hook (CONTEXT *ctx, HEADER *hdr, int type)
   HOOK *hook;
 
   current_hook_type = type;
-  
+
+  mutt_buffer_init (&err);
   err.dsize = STRING;
   err.data = safe_malloc (err.dsize);
   mutt_buffer_init (&token);
@@ -476,6 +478,7 @@ void mutt_account_hook (const char* url)
   if (inhook)
     return;
 
+  mutt_buffer_init (&err);
   err.dsize = STRING;
   err.data = safe_malloc (err.dsize);
   mutt_buffer_init (&token);

diff --git a/imap/command.c b/imap/command.c
index 092cf597ca9a774f2229a4a01674042275624306..32f84178d7ff66afa982f765c63f7d715af3c608 100644 (file)
--- a/imap/command.c
+++ b/imap/command.c
@@ -778,6 +778,7 @@ static void cmd_parse_lsub (IMAP_DATA* idata, char* s)
   url_ciss_tostring (&url, buf + 11, sizeof (buf) - 10, 0);
   safe_strcat (buf, sizeof (buf), "\"");
   mutt_buffer_init (&token);
+  mutt_buffer_init (&err);
   err.data = errstr;
   err.dsize = sizeof (errstr);
   if (mutt_parse_rc_line (buf, &token, &err))

diff --git a/imap/imap.c b/imap/imap.c
index 5173357241e657e852a268740b50f9e36ea058f6..93dc06a7f7b256793a181de77ed81fc02ef41fed 100644 (file)
--- a/imap/imap.c
+++ b/imap/imap.c
@@ -1828,6 +1828,7 @@ int imap_subscribe (char *path, int subscribe)
   if (option (OPTIMAPCHECKSUBSCRIBED))
   {
     mutt_buffer_init (&token);
+    mutt_buffer_init (&err);
     err.data = errstr;
     err.dsize = sizeof (errstr);
     snprintf (mbox, sizeof (mbox), "%smailboxes \"%s\"",