Merged revisions 78234 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/trunk

........
  r78234 | senthil.kumaran | 2010-02-19 13:02:48 +0530 (Fri, 19 Feb 2010) | 2 lines

  Fix for Issue7904. urlparse.urlsplit to handle schemes in the way defined by RFC3986
........

diff --git a/Lib/test/test_urlparse.py b/Lib/test/test_urlparse.py
index fcd19894b95eb4c49eeca4d661d42171087e3dfc..0f306a98d5a69b83bb3687b1b45d293342a0e4de 100644 (file)
--- a/Lib/test/test_urlparse.py
+++ b/Lib/test/test_urlparse.py
@@ -138,7 +138,7 @@ class UrlParseTestCase(unittest.TestCase):
                          (base, relurl, expected))
 
     def test_unparse_parse(self):
-        for u in ['Python', './Python']:
+        for u in ['Python', './Python','x-newscheme://foo.com/stuff']:
             self.assertEqual(urlparse.urlunsplit(urlparse.urlsplit(u)), u)
             self.assertEqual(urlparse.urlunparse(urlparse.urlparse(u)), u)
 
@@ -350,6 +350,15 @@ class UrlParseTestCase(unittest.TestCase):
         self.assertEqual(urlparse.urlparse("http://example.com?blahblah=/foo"),
                          ('http', 'example.com', '', '', 'blahblah=/foo', ''))
 
+    def test_anyscheme(self):
+        # Issue 7904: s3://foo.com/stuff has netloc "foo.com".
+        self.assertEqual(urlparse.urlparse("s3://foo.com/stuff"),
+                         ('s3','foo.com','/stuff','','',''))
+        self.assertEqual(urlparse.urlparse("x-newscheme://foo.com/stuff"),
+                         ('x-newscheme','foo.com','/stuff','','',''))
+
+
+
 def test_main():
     test_support.run_unittest(UrlParseTestCase)
 

diff --git a/Lib/urlparse.py b/Lib/urlparse.py
index c56d8832a01dd2300c2cc70bdec21e439a8ed36e..c41e25eea145027afc3b24d24d6fc183e62d024e 100644 (file)
--- a/Lib/urlparse.py
+++ b/Lib/urlparse.py
@@ -163,7 +163,8 @@ def urlsplit(url, scheme='', allow_fragments=True):
                 break
         else:
             scheme, url = url[:i].lower(), url[i+1:]
-    if scheme in uses_netloc and url[:2] == '//':
+
+    if url[:2] == '//':
         netloc, url = _splitnetloc(url, 2)
     if allow_fragments and scheme in uses_fragment and '#' in url:
         url, fragment = url.split('#', 1)