]> granicus.if.org Git - postgresql/commitdiff
Fix minor resource leak in pg_dump
authorMagnus Hagander <magnus@hagander.net>
Thu, 7 May 2015 09:40:15 +0000 (11:40 +0200)
committerMagnus Hagander <magnus@hagander.net>
Thu, 7 May 2015 09:41:13 +0000 (11:41 +0200)
Michael Paquier, spotted using Coverity

src/bin/pg_dump/pg_dump.c

index 977b72e344917d58a0095ffc447734a1092dd614..dccb4728f0d3c644dfa7227f9481608ddb1b4867 100644 (file)
@@ -6596,7 +6596,7 @@ getTransforms(Archive *fout, int *numTransforms)
        PGresult   *res;
        int                     ntups;
        int                     i;
-       PQExpBuffer query = createPQExpBuffer();
+       PQExpBuffer query;
        TransformInfo   *transforminfo;
        int                     i_tableoid;
        int                     i_oid;
@@ -6612,6 +6612,8 @@ getTransforms(Archive *fout, int *numTransforms)
                return NULL;
        }
 
+       query = createPQExpBuffer();
+
        /* Make sure we are in proper schema */
        selectSourceSchema(fout, "pg_catalog");