Fix error status of vacuumdb when multiple jobs are used

When running a batch of VACUUM or ANALYZE commands on a given database,
there were cases where it is possible to have vacuumdb not report an
error where it actually should, leading to incorrect status results.

Author: Julien Rouhaud
Reviewed-by: Amit Kapila, Michael Paquier
Discussion: https://postgr.es/m/CAOBaU_ZuTwz7CtqLYJ1Ouuh272bTQPLN8b1bAPk0bCBm4PDMTQ@mail.gmail.com
Backpatch-through: 9.5

diff --git a/src/bin/scripts/vacuumdb.c b/src/bin/scripts/vacuumdb.c
index 20dd1d2e6017c66a50fbe5188f450df4ef922e37..93728a3a969deff13d7928a6a2c94abe35a7277f 100644 (file)
--- a/src/bin/scripts/vacuumdb.c
+++ b/src/bin/scripts/vacuumdb.c
@@ -519,7 +519,10 @@ vacuum_one_database(const char *dbname, vacuumingOptions *vacopts,
                for (j = 0; j < concurrentCons; j++)
                {
                        if (!GetQueryResult((slots + j)->connection, progname))
+                       {
+                               failed = true;
                                goto finish;
+                       }
                }
        }