]> granicus.if.org Git - zfs/commitdiff
Correct make mancheck recipe
authorGiuseppe Di Natale <dinatale2@users.noreply.github.com>
Fri, 27 Oct 2017 16:52:18 +0000 (09:52 -0700)
committerBrian Behlendorf <behlendorf1@llnl.gov>
Fri, 27 Oct 2017 16:52:18 +0000 (09:52 -0700)
The current make recipe for mancheck silently ignores errors. Correct
the recipe so errors cause the mancheck recipe fail.

The zpool reopen command in the zpool.8 manpage had a bullet list
without an .El.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes #6790

Makefile.am
man/man8/zpool.8

index c51be2b4c5177f033206a15812fbeb7c0c65ed9a..05cafc702bd890f180fa5118eb73c51c7e91184f 100644 (file)
@@ -62,9 +62,10 @@ shellcheck:
 
 mancheck:
        @if type mandoc > /dev/null 2>&1; then \
-               for file in zfs zpool zdb zgenhostid; do \
-                       mandoc -Tlint -Werror ${top_srcdir}/man/man8/$$file.8; \
-               done \
+               find ${top_srcdir}/man/man8 -type f -name 'zfs.8' \
+                       -o -name 'zpool.8' -o -name 'zdb.8' \
+                       -o -name 'zgenhostid.8' | \
+                       xargs mandoc -Tlint -Werror; \
        fi
 
 lint: cppcheck paxcheck
index 4eea6689d857adf92f0595409947ce26c2c87573..58bf66c91dae69b439ea89c0ab82914fadc00b69 100644 (file)
@@ -1747,6 +1747,7 @@ Reopen all the vdevs associated with the pool.
 .It Fl n
 Do not restart an in-progress scrub operation. This is not recommended and can
 result in partially resilvered devices unless a second scrub is performed.
+.El
 .It Xo
 .Nm
 .Cm remove