]> granicus.if.org Git - php/commitdiff
- MFH: Fixed memory leak in readline_callback_handler_remove()
authorFelipe Pena <felipe@php.net>
Fri, 21 Nov 2008 22:27:02 +0000 (22:27 +0000)
committerFelipe Pena <felipe@php.net>
Fri, 21 Nov 2008 22:27:02 +0000 (22:27 +0000)
ext/readline/readline.c

index 766a9d79de7db42ecb1a8667869bfe50265c874b..596840d768495239c295f0ca7d40d6a5592cf699 100644 (file)
@@ -551,7 +551,8 @@ PHP_FUNCTION(readline_callback_handler_install)
 
        if (_prepped_callback) {
                rl_callback_handler_remove();
-               zval_ptr_dtor(&_prepped_callback);
+               zval_dtor(_prepped_callback);
+               FREE_ZVAL(_prepped_callback);
        }
 
        MAKE_STD_ZVAL(_prepped_callback);
@@ -580,6 +581,7 @@ PHP_FUNCTION(readline_callback_handler_remove)
 {
        if (_prepped_callback) {
                rl_callback_handler_remove();
+               zval_dtor(_prepped_callback);
                FREE_ZVAL(_prepped_callback);
                _prepped_callback = 0;
                RETURN_TRUE;