Remove wrong CloseHandle() call.

In accordance with its own documentation, invoke CloseHandle() only when
directed in the documentation for the function that furnished the
handle.  GetModuleHandle() does not so direct.  We have been issuing
this call only in the rare event that a CRT DLL contains no "_putenv"
symbol, so lack of bug reports is uninformative.  Back-patch to 9.2 (all
supported versions).

Christian Ullrich, reviewed by Michael Paquier.

diff --git a/src/port/win32env.c b/src/port/win32env.c
index e934a8f76d3a71a9165508fd66d18eec8b34dd71..40df88990fd435d07d9fa8e42cfea672801d508b 100644 (file)
--- a/src/port/win32env.c
+++ b/src/port/win32env.c
@@ -86,7 +86,6 @@ pgwin32_putenv(const char *envval)
                                        rtmodules[i].putenvFunc = (PUTENVPROC) GetProcAddress(rtmodules[i].hmodule, "_putenv");
                                        if (rtmodules[i].putenvFunc == NULL)
                                        {
-                                               CloseHandle(rtmodules[i].hmodule);
                                                rtmodules[i].hmodule = INVALID_HANDLE_VALUE;
                                                continue;
                                        }