]> granicus.if.org Git - python/commitdiff
Merged revisions 86003 via svnmerge from
authorBrian Curtin <brian.curtin@gmail.com>
Sun, 31 Oct 2010 00:05:24 +0000 (00:05 +0000)
committerBrian Curtin <brian.curtin@gmail.com>
Sun, 31 Oct 2010 00:05:24 +0000 (00:05 +0000)
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r86003 | brian.curtin | 2010-10-30 19:03:45 -0500 (Sat, 30 Oct 2010) | 2 lines

  Fix ResourceWarning. Use context manager to properly close file.
........

Lib/test/test_float.py

index fa6fde32810a84bb2e89fcb8e8e063f1bcddc43f..bdaf0820f0fd38f77164a813b3d80df9959f04f3 100644 (file)
@@ -401,17 +401,18 @@ class FormatTestCase(unittest.TestCase):
     @unittest.skipUnless(float.__getformat__("double").startswith("IEEE"),
                          "test requires IEEE 754 doubles")
     def test_format_testfile(self):
-        for line in open(format_testfile):
-            if line.startswith('--'):
-                continue
-            line = line.strip()
-            if not line:
-                continue
-
-            lhs, rhs = map(str.strip, line.split('->'))
-            fmt, arg = lhs.split()
-            self.assertEqual(fmt % float(arg), rhs)
-            self.assertEqual(fmt % -float(arg), '-' + rhs)
+        with open(format_testfile) as testfile:
+            for line in testfile:
+                if line.startswith('--'):
+                    continue
+                line = line.strip()
+                if not line:
+                    continue
+
+                lhs, rhs = map(str.strip, line.split('->'))
+                fmt, arg = lhs.split()
+                self.assertEqual(fmt % float(arg), rhs)
+                self.assertEqual(fmt % -float(arg), '-' + rhs)
 
     def test_issue5864(self):
         self.assertEquals(format(123.456, '.4'), '123.5')