Issue #9128: Validate class decorator syntax correctly in parser module.

diff --git a/Lib/test/test_parser.py b/Lib/test/test_parser.py
index dca904cb63d4b5889ad6523b2040247dc27232e0..a964877e3176403bd1be379bd5640d2fa1da6085 100644 (file)
--- a/Lib/test/test_parser.py
+++ b/Lib/test/test_parser.py
@@ -180,6 +180,14 @@ class RoundtripLegalSyntaxTestCase(unittest.TestCase):
 
     def test_class_defs(self):
         self.check_suite("class foo():pass")
+        self.check_suite("@class_decorator\n"
+                         "class foo():pass")
+        self.check_suite("@class_decorator(arg)\n"
+                         "class foo():pass")
+        self.check_suite("@decorator1\n"
+                         "@decorator2\n"
+                         "class foo():pass")
+
 
     def test_import_from_statement(self):
         self.check_suite("from sys.path import *")

diff --git a/Misc/NEWS b/Misc/NEWS
index 3eb67a388d646d8b04348dca62097673ac3734f7..3a867a5d62b69c58c22b97761d44979de05b50ad 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -16,6 +16,7 @@ Core and Builtins
 Library
 -------
 
+- Issue #9128: Fix validation of class decorators in parser module.
 
 Extension Modules
 -----------------

diff --git a/Modules/parsermodule.c b/Modules/parsermodule.c
index 5d1bfb6674eb72f5d0eeb0b773828fcb71654011..4a581d75867333d7d567760addb71f7e6c80f6a5 100644 (file)
--- a/Modules/parsermodule.c
+++ b/Modules/parsermodule.c
@@ -2682,14 +2682,15 @@ validate_funcdef(node *tree)
 static int
 validate_decorated(node *tree)
 {
-  int nch = NCH(tree);
-  int ok = (validate_ntype(tree, decorated)
-            && (nch == 2)
-            && validate_decorators(RCHILD(tree, -2))
-            && (validate_funcdef(RCHILD(tree, -1))
-                || validate_class(RCHILD(tree, -1)))
-            );
-  return ok;
+    int nch = NCH(tree);
+    int ok = (validate_ntype(tree, decorated)
+              && (nch == 2)
+              && validate_decorators(RCHILD(tree, -2)));
+    if (TYPE(RCHILD(tree, -1)) == funcdef)
+        ok = ok && validate_funcdef(RCHILD(tree, -1));
+    else
+        ok = ok && validate_class(RCHILD(tree, -1));
+    return ok;
 }
 
 static int