]> granicus.if.org Git - python/commitdiff
Coverity found refleak: need to free 'v' after calling Tkinter_Error().
authorThomas Wouters <thomas@python.org>
Tue, 7 Mar 2006 14:04:31 +0000 (14:04 +0000)
committerThomas Wouters <thomas@python.org>
Tue, 7 Mar 2006 14:04:31 +0000 (14:04 +0000)
Will backport to release24.

Modules/_tkinter.c

index 03f145327912890328847ad1f575ec096130ba58..b85e15844cf3d17a0bb70d43956039145068ddc7 100644 (file)
@@ -686,8 +686,11 @@ Tkapp_New(char *screenName, char *baseName, char *className,
                ckfree(args);
        }
 
-       if (Tcl_AppInit(v->interp) != TCL_OK)
-               return (TkappObject *)Tkinter_Error((PyObject *)v);
+       if (Tcl_AppInit(v->interp) != TCL_OK) {
+               PyObject *result = Tkinter_Error((PyObject *)v);
+               Py_DECREF((PyObject *)v);
+               return (TkappObject *)result;
+       }
 
        EnableEventHook();