Avoid using !strcmp()

diff --git a/plugins/sudoers/ldap.c b/plugins/sudoers/ldap.c
index 17cb8eaa7e000cbfd55a7c4ac0b9658cfa482c5c..f745a9c796486ed6787cf6c3fee57e225486e7f8 100644 (file)
--- a/plugins/sudoers/ldap.c
+++ b/plugins/sudoers/ldap.c
@@ -736,7 +736,7 @@ sudo_ldap_check_host(LDAP *ld, LDAPMessage *entry, struct passwd *pw)
     for (p = bv; *p != NULL && !ret; p++) {
        val = (*p)->bv_val;
        /* match any or address or netgroup or hostname */
-       if (!strcmp(val, "ALL") || addr_matches(val) ||
+       if (strcmp(val, "ALL") == 0 || addr_matches(val) ||
            netgr_matches(val, user_runhost, user_srunhost,
            def_netgroup_tuple ? pw->pw_name : NULL) ||
            hostname_matches(user_srunhost, user_runhost, val))
@@ -958,7 +958,7 @@ sudo_ldap_check_command(LDAP *ld, LDAPMessage *entry, int *setenv_implied)
     for (p = bv; *p != NULL && ret != false; p++) {
        val = (*p)->bv_val;
        /* Match against ALL ? */
-       if (!strcmp(val, "ALL")) {
+       if (strcmp(val, "ALL") == 0) {
            ret = true;
            if (setenv_implied != NULL)
                *setenv_implied = true;

diff --git a/plugins/sudoers/sssd.c b/plugins/sudoers/sssd.c
index 74c2c1a543c89b500b692d1068d98eee5fc6a160..23a486cf7fabdefafae43ad6a3c9657150752e89 100644 (file)
--- a/plugins/sudoers/sssd.c
+++ b/plugins/sudoers/sssd.c
@@ -673,7 +673,7 @@ sudo_sss_check_host(struct sudo_sss_handle *handle, struct sss_sudo_rule *rule)
        sudo_debug_printf(SUDO_DEBUG_DEBUG, "val[%d]=%s", i, val);
 
        /* match any or address or netgroup or hostname */
-       if (!strcmp(val, "ALL") || addr_matches(val) || netgr_matches(val,
+       if (strcmp(val, "ALL") == 0 || addr_matches(val) || netgr_matches(val,
            user_runhost, user_srunhost, handle->pw->pw_name) ||
            hostname_matches(user_srunhost, user_runhost, val))
            ret = true;
@@ -991,7 +991,7 @@ sudo_sss_check_command(struct sudo_sss_handle *handle,
        sudo_debug_printf(SUDO_DEBUG_DEBUG, "val[%d]=%s", i, val);
 
        /* Match against ALL ? */
-       if (!strcmp(val, "ALL")) {
+       if (strcmp(val, "ALL") == 0) {
            ret = true;
            if (setenv_implied != NULL)
                *setenv_implied = true;