Reduce chattiness of genbki.pl and Gen_fmgrtab.pl.

Make these scripts emit just one log message when they run, not one
per output file.  The latter is way too verbose in the wake of
commit 372728b0d.  The specific wording used is what already existed
in the MSVC scripts.

John Naylor

Discussion: https://postgr.es/m/11103.1523208822@sss.pgh.pa.us

diff --git a/src/backend/catalog/Catalog.pm b/src/backend/catalog/Catalog.pm
index 3b3bb6bc6ca7315272105334ff0b0e6b7927690b..02bd6d43836b9ff18dc0b7d3eb5b3fa74116185d 100644 (file)
--- a/src/backend/catalog/Catalog.pm
+++ b/src/backend/catalog/Catalog.pm
@@ -340,7 +340,6 @@ sub RenameTempFile
        my $final_name = shift;
        my $extension  = shift;
        my $temp_name  = $final_name . $extension;
-       print "Writing $final_name\n";
        rename($temp_name, $final_name) || die "rename: $temp_name: $!";
 }
 

diff --git a/src/backend/catalog/genbki.pl b/src/backend/catalog/genbki.pl
index 56312ded8a0220015263c62db24424b32748f4f7..cd68fc31088bad255752147a2d9c8d5175f94973 100644 (file)
--- a/src/backend/catalog/genbki.pl
+++ b/src/backend/catalog/genbki.pl
@@ -217,6 +217,7 @@ my %lookup_kind = (
 
 # Generate postgres.bki, postgres.description, postgres.shdescription,
 # and pg_*_d.h headers.
+print "Generating BKI files and symbol definition headers...\n";
 
 # version marker for .bki file
 print $bki "# PostgreSQL $major_version\n";

diff --git a/src/backend/utils/Gen_fmgrtab.pl b/src/backend/utils/Gen_fmgrtab.pl
index 3b112c69d8e1f4d7a454624444933979a2d81bec..4f5af79d0b565c4c3c8cf1fa0b6e168742349259 100644 (file)
--- a/src/backend/utils/Gen_fmgrtab.pl
+++ b/src/backend/utils/Gen_fmgrtab.pl
@@ -84,6 +84,8 @@ my $FirstBootstrapObjectId = Catalog::FindDefinedSymbol(
 my $INTERNALlanguageId = Catalog::FindDefinedSymbolFromData(
        $catalog_data{pg_language}, 'INTERNALlanguageId');
 
+print "Generating fmgrtab.c, fmgroids.h, and fmgrprotos.h...\n";
+
 # Collect certain fields from pg_proc.dat.
 my @fmgr = ();
 

diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm
index b267c19438f3795d80401a9e3b5d342ecaf343bd..f9534605231ac284f2e2e03ad83c8090316543b9 100644 (file)
--- a/src/tools/msvc/Solution.pm
+++ b/src/tools/msvc/Solution.pm
@@ -275,7 +275,6 @@ s{PG_VERSION_STR "[^"]+"}{PG_VERSION_STR "PostgreSQL $self->{strver}$extraver, c
                        'fmgrtab.c', '../../../src/include/access/transam.h')
                )
        {
-               print "Generating fmgrtab.c, fmgroids.h, fmgrprotos.h...\n";
                system(
 "perl -I ../catalog Gen_fmgrtab.pl -I../../../src/include/ $pg_language_dat $pg_proc_dat");
        }
@@ -479,7 +478,6 @@ EOF
                                'src/backend/catalog/postgres.bki',
                                "src/include/catalog/$bki"))
                {
-                       print "Generating BKI files and symbol definition headers...\n";
                        chdir('src/backend/catalog');
                        my $bki_srcs = join(' ../../../src/include/catalog/', @bki_srcs);
                        system("perl genbki.pl --set-version=$self->{majorver} $bki_srcs");