]> granicus.if.org Git - llvm/commitdiff
[llvm-cov] Document a few private fields of CodeCoverageTool (NFC)
authorVedant Kumar <vsk@apple.com>
Fri, 15 Jul 2016 22:44:54 +0000 (22:44 +0000)
committerVedant Kumar <vsk@apple.com>
Fri, 15 Jul 2016 22:44:54 +0000 (22:44 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@275639 91177308-0d34-0410-b5e6-96231b3b80d8

tools/llvm-cov/CodeCoverage.cpp
tools/llvm-cov/CoverageViewOptions.h

index ed48c28c0fc7faf0e463b32d52f267f591f16387..59cb708a42c1ff29c82f957367ca8a1de1ed7bf5 100644 (file)
@@ -101,11 +101,14 @@ public:
   std::string CoverageArch;
 
 private:
+  /// File paths (absolute, or otherwise) to input source files.
   std::vector<std::string> CollectedPaths;
 
+  /// Errors and warnings which have not been printed.
   std::mutex DeferredMessagesLock;
   std::vector<std::string> DeferredMessages;
 
+  /// A container for input source file buffers.
   std::mutex LoadedSourceFilesLock;
   std::vector<std::pair<std::string, std::unique_ptr<MemoryBuffer>>>
       LoadedSourceFiles;
index 873eae885a7bedeab105fe71cb65ceffb2c99fac..eafc0cfd16517a60c02073ee52ed2b66d028b5d2 100644 (file)
@@ -40,7 +40,7 @@ struct CoverageViewOptions {
   }
 
   /// \brief Check if an output directory has been specified.
-  bool hasOutputDirectory() const { return ShowOutputDirectory != ""; }
+  bool hasOutputDirectory() const { return !ShowOutputDirectory.empty(); }
 };
 }