]> granicus.if.org Git - python/commitdiff
bpo-35031, test_asycio: disable TLS 1.3 in test_start_tls_server_1() (GH-14148)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 17 Jun 2019 10:06:41 +0000 (03:06 -0700)
committerGitHub <noreply@github.com>
Mon, 17 Jun 2019 10:06:41 +0000 (03:06 -0700)
bpo-35031, bpo-35998: Reintroduce workaround on Windows and FreeBSD
in test_start_tls_server_1() of test_asyncio: disable TLS v1.3 on the
client context.
(cherry picked from commit c034b7824f5a7c50f2946ab3931633200e31d903)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Lib/test/test_asyncio/test_sslproto.py

index 5c861e92b7d67cb9ce5cacf3daa88ca0829034ea..4645cc044a592957f4b3268be4f14fbc7a329e17 100644 (file)
@@ -498,6 +498,12 @@ class BaseStartTLS(func_tests.FunctionalTestCaseMixin):
 
         server_context = test_utils.simple_server_sslcontext()
         client_context = test_utils.simple_client_sslcontext()
+        if sys.platform.startswith('freebsd') or sys.platform.startswith('win'):
+            # bpo-35031: Some FreeBSD and Windows buildbots fail to run this test
+            # as the eof was not being received by the server if the payload
+            # size is not big enough. This behaviour only appears if the
+            # client is using TLS1.3.
+            client_context.options |= ssl.OP_NO_TLSv1_3
         answer = None
 
         def client(sock, addr):