]> granicus.if.org Git - clang/commitdiff
[OpenMP] Fix translation of target args
authorJonas Hahnfeld <hahnjo@hahnjo.de>
Wed, 27 Sep 2017 18:12:36 +0000 (18:12 +0000)
committerJonas Hahnfeld <hahnjo@hahnjo.de>
Wed, 27 Sep 2017 18:12:36 +0000 (18:12 +0000)
ToolChain::TranslateArgs() returns nullptr if no changes are performed.
This would currently mean that OpenMPArgs are lost. Patch fixes this
by falling back to simply using OpenMPArgs in that case.

Differential Revision: https://reviews.llvm.org/D38259

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@314330 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Driver/Compilation.cpp

index fe2a18131c9b5353a1d3be836627e3c5c0e13346..b3991dad3a8380f3330cf6b7cca5f6dff0b4c2eb 100644 (file)
@@ -57,14 +57,16 @@ Compilation::getArgsForToolChain(const ToolChain *TC, StringRef BoundArch,
         *TranslatedArgs, DeviceOffloadKind, AllocatedArgs);
     if (!OpenMPArgs) {
       Entry = TC->TranslateArgs(*TranslatedArgs, BoundArch, DeviceOffloadKind);
+      if (!Entry)
+        Entry = TranslatedArgs;
     } else {
       Entry = TC->TranslateArgs(*OpenMPArgs, BoundArch, DeviceOffloadKind);
-      delete OpenMPArgs;
+      if (!Entry)
+        Entry = OpenMPArgs;
+      else
+        delete OpenMPArgs;
     }
 
-    if (!Entry)
-      Entry = TranslatedArgs;
-
     // Add allocated arguments to the final DAL.
     for (auto ArgPtr : AllocatedArgs) {
       Entry->AddSynthesizedArg(ArgPtr);