]> granicus.if.org Git - php/commitdiff
Fix compile warnings about comparison of unsigned expression always being true
authorChristopher Jones <christopher.jones@oracle.com>
Fri, 6 Nov 2015 15:14:18 +0000 (02:14 +1100)
committerChristopher Jones <christopher.jones@oracle.com>
Fri, 6 Nov 2015 15:14:18 +0000 (02:14 +1100)
ext/oci8/oci8_interface.c
ext/oci8/oci8_lob.c

index bb7212290d3ad21d53ed62fe46247e55ab064989..817b8dbf8b5ec072f86f1ca34dd73f488c8a8558 100644 (file)
@@ -373,7 +373,7 @@ PHP_FUNCTION(oci_lob_eof)
        
        PHP_OCI_ZVAL_TO_DESCRIPTOR(*tmp, descriptor);
        
-       if (!php_oci_lob_get_length(descriptor, &lob_length TSRMLS_CC) && lob_length >= 0) {
+       if (!php_oci_lob_get_length(descriptor, &lob_length TSRMLS_CC)) {
                if (lob_length == descriptor->lob_current_position) {
                        RETURN_TRUE;
                }
index ca08373ff2fdd2a3ca7d518e9f9c37b9432a4bba..079e0a6a8f955937516e9c3bfb1e076b04cdd87f 100644 (file)
@@ -417,10 +417,6 @@ int php_oci_lob_write (php_oci_descriptor *descriptor, ub4 offset, char *data, i
                return 0;
        }
        
-       if (offset < 0) {
-               offset = 0;
-       }
-       
        if (offset > descriptor->lob_current_position) {
                offset = descriptor->lob_current_position;
        }