]> granicus.if.org Git - clang/commitdiff
clang-format: [JS] Fix incorrect line length calculation.
authorDaniel Jasper <djasper@google.com>
Tue, 2 Jun 2015 15:14:21 +0000 (15:14 +0000)
committerDaniel Jasper <djasper@google.com>
Tue, 2 Jun 2015 15:14:21 +0000 (15:14 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@238841 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestJS.cpp

index 39b2793feef9b64d11a2aea6ab61ddf61fec9d70..204bcc9df4f2453deb86b3e1be0a7fb4e29d6117 100644 (file)
@@ -159,7 +159,8 @@ bool ContinuationIndenter::mustBreak(const LineState &State) {
   if (((Previous.is(TT_DictLiteral) && Previous.is(tok::l_brace)) ||
        Previous.is(TT_ArrayInitializerLSquare)) &&
       Style.ColumnLimit > 0 &&
-      getLengthToMatchingParen(Previous) + State.Column > getColumnLimit(State))
+      getLengthToMatchingParen(Previous) + State.Column - 1 >
+          getColumnLimit(State))
     return true;
   if (Current.is(TT_CtorInitializerColon) &&
       ((Style.AllowShortFunctionsOnASingleLine != FormatStyle::SFS_All) ||
index 25113ab75896dbdb22d9636b2b1b4f68152ed277..a18d35b034a7312f1ffa6e3ecd865d96182c08d0 100644 (file)
@@ -259,7 +259,8 @@ TEST_F(FormatTestJS, ArrayLiterals) {
                "]);");
   verifyFormat("var someVariable = SomeFuntion([\n"
                "  [aaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbb],\n"
-               "]);");
+               "]);",
+               getGoogleJSStyleWithColumns(51));
   verifyFormat("var someVariable = SomeFuntion(aaaa, [\n"
                "  aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
                "  bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"