Fixing compiler warning about missing virtual destructor in class with virtual methods

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@706328 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

diff --git a/taglib/fileref.cpp b/taglib/fileref.cpp
index 2aaaa24089cdd84a175a589bf63d3cab6e85235a..0b0a49a31e697b87888b05895d5784031b3db088 100644 (file)
--- a/taglib/fileref.cpp
+++ b/taglib/fileref.cpp
@@ -48,6 +48,10 @@ List<const FileRef::FileTypeResolver *> FileRef::FileRefPrivate::fileTypeResolve
 // public members
 ////////////////////////////////////////////////////////////////////////////////
 
+FileRef::FileTypeResolver::~FileTypeResolver()
+{
+}
+
 FileRef::FileRef()
 {
     d = new FileRefPrivate(0);
@@ -171,7 +175,7 @@ File *FileRef::create(const char *fileName, bool readAudioProperties,
       return new FLAC::File(fileName, readAudioProperties, audioPropertiesStyle);
     if(s.substr(s.size() - 4, 4).upper() == ".MPC")
       return new MPC::File(fileName, readAudioProperties, audioPropertiesStyle);
-  }  
+  }
 
   return 0;
 }

diff --git a/taglib/fileref.h b/taglib/fileref.h
index 60db142582cc950a58e909f3458140db5307fe23..b4f1c46eaeba637fef07c0faf0b049b6583d239e 100644 (file)
--- a/taglib/fileref.h
+++ b/taglib/fileref.h
@@ -56,7 +56,7 @@ namespace TagLib {
   class TAGLIB_EXPORT FileRef
   {
   public:
-    
+
   //! A class for pluggable file type resolution.
 
   /*!
@@ -89,6 +89,10 @@ namespace TagLib {
     class FileTypeResolver
     {
     public:
+      /*!
+       * Destroys this FileTypeResolver instance.
+       */
+      virtual ~FileTypeResolver();
       /*!
        * This method must be overridden to provide an additional file type
        * resolver.  If the resolver is able to determine the file type it should

diff --git a/taglib/mpeg/id3v1/id3v1tag.cpp b/taglib/mpeg/id3v1/id3v1tag.cpp
index f6fb501e597b2415cb848ec70a43e6dc19495445..b336a48430860a277b87be7d0c8634feea19309e 100644 (file)
--- a/taglib/mpeg/id3v1/id3v1tag.cpp
+++ b/taglib/mpeg/id3v1/id3v1tag.cpp
@@ -53,6 +53,10 @@ const ID3v1::StringHandler *ID3v1::Tag::TagPrivate::stringHandler = new StringHa
 // StringHandler implementation
 ////////////////////////////////////////////////////////////////////////////////
 
+ID3v1::StringHandler::~StringHandler()
+{
+}
+
 String ID3v1::StringHandler::parse(const ByteVector &data) const
 {
   return String(data, String::Latin1).stripWhiteSpace();

diff --git a/taglib/mpeg/id3v1/id3v1tag.h b/taglib/mpeg/id3v1/id3v1tag.h
index 9046232a2ef0f76e3216d7dee3bc0edddafcb85e..baef325bd086bb5d6564560cc3e7333ecbfb37ba 100644 (file)
--- a/taglib/mpeg/id3v1/id3v1tag.h
+++ b/taglib/mpeg/id3v1/id3v1tag.h
@@ -56,6 +56,10 @@ namespace TagLib {
     class StringHandler
     {
     public:
+      /*!
+       * Destroys this StringHandler instance.
+       */
+      virtual ~StringHandler();
       /*!
        * Decode a string from \a data.  The default implementation assumes that
        * \a data is an ISO-8859-1 (Latin1) character array.