Backout buggy patch committed for #13719

diff --git a/Lib/distutils/command/bdist_msi.py b/Lib/distutils/command/bdist_msi.py
index fde0f63fea233297a8bedf0f010bc575eb89aa36..b3cfe9ceff7640cf80684ce63e11bc15ab76e848 100644 (file)
--- a/Lib/distutils/command/bdist_msi.py
+++ b/Lib/distutils/command/bdist_msi.py
@@ -260,7 +260,7 @@ class bdist_msi(Command):
         self.db.Commit()
 
         if hasattr(self.distribution, 'dist_files'):
-            tup = 'bdist_msi', self.target_version or 'any', installer_name
+            tup = 'bdist_msi', self.target_version or 'any', fullname
             self.distribution.dist_files.append(tup)
 
         if not self.keep_temp:

diff --git a/Lib/distutils/tests/test_bdist_msi.py b/Lib/distutils/tests/test_bdist_msi.py
index e5994610701315ca7c27eeef0bc9bd2f58c21acd..15d8bdff2b4f559fc359ceb67c5b1cf13d6bc23d 100644 (file)
--- a/Lib/distutils/tests/test_bdist_msi.py
+++ b/Lib/distutils/tests/test_bdist_msi.py
@@ -1,5 +1,4 @@
 """Tests for distutils.command.bdist_msi."""
-import os
 import sys
 import unittest
 from test.support import run_unittest
@@ -17,14 +16,6 @@ class BDistMSITestCase(support.TempdirManager,
         project_dir, dist = self.create_dist()
         cmd = bdist_msi(dist)
         cmd.ensure_finalized()
-        cmd.run()
-
-        bdists = os.listdir(os.path.join(project_dir, 'dist'))
-        self.assertEqual(bdists, ['foo-0.1.msi'])
-
-        # bug #13719: upload ignores bdist_msi files
-        self.assertEqual(dist.dist_files,
-                         [('bdist_msi', 'any', 'dist/foo-0.1.msi')])
 
 
 def test_suite():

diff --git a/Misc/NEWS b/Misc/NEWS
index 250dd81fd9dd6172a4c9d19a0a5a5aaa5bb6eb91..cd0024e17a24cf36183cafdea97ce1e2fe34d0b5 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -130,8 +130,6 @@ Core and Builtins
 Library
 -------
 
-- Issue #13719: Make the distutils upload command aware of bdist_msi products.
-
 - Issue #14195: An issue that caused weakref.WeakSet instances to incorrectly
   return True for a WeakSet instance 'a' in both 'a < a' and 'a > a' has been
   fixed.