]> granicus.if.org Git - pdns/commitdiff
dnsdist: Compile with -Wall -Wextra -Wshadow by default
authorRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 3 Oct 2019 13:41:46 +0000 (15:41 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 3 Oct 2019 13:41:46 +0000 (15:41 +0200)
And -Werror=vla -Werror=shadow -Wformat=2 -Werror=format-security
in CircleCI.

.circleci/config.yml
pdns/dnsdistdist/configure.ac

index 6e5084cc0a45c8dd26c8b1727e5ac8d32182a202..7ea68d4abcf7bf8748dbcf0be2e4f50b3da09ef7 100644 (file)
@@ -1097,8 +1097,8 @@ jobs:
       - run:
           name: configure
           command: |
-            CFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security" \
-            CXXFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
+            CFLAGS="-O1 -Werror=vla -Werror=shadow -Wformat=2 -Werror=format-security" \
+            CXXFLAGS="-O1 -Werror=vla -Werror=shadow -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
             ./configure \
             --disable-systemd \
             --disable-unit-tests \
@@ -1247,8 +1247,8 @@ jobs:
       - run:
           name: configure
           command: |
-            CFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security" \
-            CXXFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
+            CFLAGS="-O1 -Werror=vla -Werror=shadow -Wformat=2 -Werror=format-security" \
+            CXXFLAGS="-O1 -Werror=vla -Werror=shadow -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \
             ./configure \
             --enable-unit-tests \
             --enable-dnstap \
index 88eabe39dbb6ca2d2e42101b8842480cff36c9de..3b34f371be8a3b725bacd8451c3a62022e388879 100644 (file)
@@ -17,8 +17,8 @@ AC_DEFINE([DNSDIST], [1],
 LT_PREREQ([2.2.2])
 LT_INIT([disable-static])
 
-CFLAGS="-Wall -g -O3 $CFLAGS"
-CXXFLAGS="-Wall -g -O3 $CXXFLAGS"
+CFLAGS="-Wall -g -O3 $CFLAGS -Wall -Wextra -Wshadow -Wno-unused-parameter"
+CXXFLAGS="-Wall -g -O3 $CXXFLAGS -Wall -Wextra -Wshadow -Wno-unused-parameter"
 
 PDNS_WITH_LIBSODIUM
 PDNS_CHECK_DNSTAP([auto])