Using session_save_path() after starting session is obvious error.

Riase E_NOTICE error instead of E_WARNING. Since it is valid if
user uses session_save_path() with session_module_name().

diff --git a/ext/session/session.c b/ext/session/session.c
index 5e6964d9957a8ebe02d708d235d395d658695a31..58c2bb51078e88c1f75b522dc4873e520f47a923 100644 (file)
--- a/ext/session/session.c
+++ b/ext/session/session.c
@@ -1122,8 +1122,13 @@ PHP_FUNCTION(session_set_save_handler)
        if (ZEND_NUM_ARGS() != 6 || zend_get_parameters_array_ex(6, args) == FAILURE)
                WRONG_PARAM_COUNT;
        
-       if (PS(session_status) != php_session_none) 
+       if (PS(session_status) != php_session_none) {
+               php_error(E_NOTICE, "%s() cannot set session save handler functions once session is started. "
+                                 "Current session save handler (%s)",
+                                 get_active_function_name(TSRMLS_C),
+                                 (PS(mod)->name ? PS(mod)->name : "none"));
                RETURN_FALSE;
+       }
        
        zend_alter_ini_entry("session.save_handler", sizeof("session.save_handler"), "user", sizeof("user")-1, PHP_INI_USER, PHP_INI_STAGE_RUNTIME);