]> granicus.if.org Git - zfs/commitdiff
zhack: fix getopt return type
authorNathaniel Wesley Filardo <VP331RHQ115POU58JFRLKB7OPA0L18E3@cmx.ietfng.org>
Tue, 9 Jan 2018 19:14:45 +0000 (14:14 -0500)
committerTony Hutter <hutter2@llnl.gov>
Tue, 30 Jan 2018 16:27:31 +0000 (10:27 -0600)
This fixes zhack's command processing on ARM.  On ARM char
is unsigned, and so, in promotion to an int, it will never
compare equal to -1.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Nathaniel Wesley Filardo <nwf@cs.jhu.edu>
Closes #7016

cmd/zhack/zhack.c

index 70f88fc6987469d1341d8ff36367ce7ba0abf23a..e15af8f4ea02eb207c5f3cd89b9bbd79d1f39c44 100644 (file)
@@ -268,7 +268,7 @@ zhack_feature_enable_sync(void *arg, dmu_tx_t *tx)
 static void
 zhack_do_feature_enable(int argc, char **argv)
 {
-       char c;
+       int c;
        char *desc, *target;
        spa_t *spa;
        objset_t *mos;
@@ -363,7 +363,7 @@ feature_decr_sync(void *arg, dmu_tx_t *tx)
 static void
 zhack_do_feature_ref(int argc, char **argv)
 {
-       char c;
+       int c;
        char *target;
        boolean_t decr = B_FALSE;
        spa_t *spa;
@@ -483,7 +483,7 @@ main(int argc, char **argv)
        char *path[MAX_NUM_PATHS];
        const char *subcommand;
        int rv = 0;
-       char c;
+       int c;
 
        g_importargs.path = path;