]> granicus.if.org Git - apache/commitdiff
Follow-up to r1540161:
authorJeff Trawick <trawick@apache.org>
Fri, 15 Nov 2013 21:52:58 +0000 (21:52 +0000)
committerJeff Trawick <trawick@apache.org>
Fri, 15 Nov 2013 21:52:58 +0000 (21:52 +0000)
The last arg to apr_file_write_full() isn't needed
unless you need to know the number of bytes written before
an error occurred.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1542413 13f79535-47bb-0310-9956-ffa450edef68

modules/slotmem/mod_slotmem_shm.c

index f12b03322963e60f1f7e3cb9dee589727c71de32..1f7e557cd9dc0ba681070ad24a7aa8bff14e1e86 100644 (file)
@@ -179,7 +179,6 @@ static void store_slotmem(ap_slotmem_instance_t *slotmem)
     apr_size_t nbytes;
     const char *storename;
     unsigned char digest[APR_MD5_DIGESTSIZE];
-    apr_size_t written = 0;
 
     storename = slotmem_filename(slotmem->gpool, slotmem->name, 1);
 
@@ -203,12 +202,12 @@ static void store_slotmem(ap_slotmem_instance_t *slotmem)
         nbytes = (slotmem->desc.size * slotmem->desc.num) +
                  (slotmem->desc.num * sizeof(char)) + AP_UNSIGNEDINT_OFFSET;
         apr_md5(digest, slotmem->persist, nbytes);
-        rv = apr_file_write_full(fp, slotmem->persist, nbytes, &written);
-        if (rv == APR_SUCCESS && written == nbytes) {
-            rv = apr_file_write_full(fp, digest, APR_MD5_DIGESTSIZE, &written);
+        rv = apr_file_write_full(fp, slotmem->persist, nbytes, NULL);
+        if (rv == APR_SUCCESS) {
+            rv = apr_file_write_full(fp, digest, APR_MD5_DIGESTSIZE, NULL);
         }
         apr_file_close(fp);
-        if (rv != APR_SUCCESS || written != APR_MD5_DIGESTSIZE) {
+        if (rv != APR_SUCCESS) {
             apr_file_remove(storename, slotmem->gpool);
         }
     }