]> granicus.if.org Git - postgresql/commitdiff
test_ddl_deparse: Don't use pg_class as source for a matview
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 15 Mar 2018 12:51:12 +0000 (09:51 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 15 Mar 2018 12:57:20 +0000 (09:57 -0300)
Doing so causes a pg_upgrade of a database containing these objects to
fail whenever pg_class changes.  And it's pointless anyway: we have more
interesting tables anyhow.

Discussion: https://postgr.es/m/CAD5tBc+s8pW9WvH2+_z=B4x95FD4QuzZKcaMpff_9H4rS0VU1A@mail.gmail.com

src/test/modules/test_ddl_deparse/expected/matviews.out
src/test/modules/test_ddl_deparse/sql/matviews.sql

index b946ff06d262a27068dca2a10181bfeaee9cdaa9..4ac2cc832535b12c06d69364d1eeba2a3899e432 100644 (file)
@@ -2,7 +2,7 @@
 -- Materialized views
 --
 CREATE MATERIALIZED VIEW pg_class_mv AS
-  SELECT * FROM pg_class LIMIT 1 WITH NO DATA;
+  SELECT * FROM datatype_table LIMIT 1 WITH NO DATA;
 NOTICE:  DDL test: type simple, tag CREATE MATERIALIZED VIEW
 REFRESH MATERIALIZED VIEW pg_class_mv;
 NOTICE:  DDL test: type simple, tag REFRESH MATERIALIZED VIEW
index 381c11e1f8488d2d59191eb2937b312cb7ade3ca..990082934e3aa02ea1152c895338d7e3c5ae7f33 100644 (file)
@@ -3,6 +3,6 @@
 --
 
 CREATE MATERIALIZED VIEW pg_class_mv AS
-  SELECT * FROM pg_class LIMIT 1 WITH NO DATA;
+  SELECT * FROM datatype_table LIMIT 1 WITH NO DATA;
 
 REFRESH MATERIALIZED VIEW pg_class_mv;