Rephrase a few comments for clarity.

I was confused by what "intended to be parallel serially" meant, until
Robert Haas and David G. Johnston explained it. Rephrase the comment to
make it more clear, using David's suggested wording.

Discussion: https://www.postgresql.org/message-id/1fec9022-41e8-e484-70ce-2179b08c2092%40iki.fi

diff --git a/src/backend/executor/nodeIndexonlyscan.c b/src/backend/executor/nodeIndexonlyscan.c
index b912f4b7a5ca60bc0cf2439f90c48680c43ac334..f452e0fd5ff1271b002e7173b6006add2abcf132 100644 (file)
--- a/src/backend/executor/nodeIndexonlyscan.c
+++ b/src/backend/executor/nodeIndexonlyscan.c
@@ -84,8 +84,8 @@ IndexOnlyNext(IndexOnlyScanState *node)
        {
                /*
                 * We reach here if the index only scan is not parallel, or if we're
-                * executing a index only scan that was intended to be parallel
-                * serially.
+                * serially executing an index only scan that was planned to be
+                * parallel.
                 */
                scandesc = index_beginscan(node->ss.ss_currentRelation,
                                                                   node->ioss_RelationDesc,

diff --git a/src/backend/executor/nodeIndexscan.c b/src/backend/executor/nodeIndexscan.c
index f46bc23ae8548bd51211685c966ff3ee0c16a653..700d7635f3c2dfc3cbeb55f13a3b726e750c9c56 100644 (file)
--- a/src/backend/executor/nodeIndexscan.c
+++ b/src/backend/executor/nodeIndexscan.c
@@ -108,7 +108,7 @@ IndexNext(IndexScanState *node)
        {
                /*
                 * We reach here if the index scan is not parallel, or if we're
-                * executing a index scan that was intended to be parallel serially.
+                * serially executing an index scan that was planned to be parallel.
                 */
                scandesc = index_beginscan(node->ss.ss_currentRelation,
                                                                   node->iss_RelationDesc,
@@ -215,7 +215,7 @@ IndexNextWithReorder(IndexScanState *node)
        {
                /*
                 * We reach here if the index scan is not parallel, or if we're
-                * executing a index scan that was intended to be parallel serially.
+                * serially executing an index scan that was planned to be parallel.
                 */
                scandesc = index_beginscan(node->ss.ss_currentRelation,
                                                                   node->iss_RelationDesc,

diff --git a/src/backend/executor/nodeSeqscan.c b/src/backend/executor/nodeSeqscan.c
index d4ac939c9b068785a8fe4ac7990af8fec1aeb587..18c246e49a0389384cad8aa2390739c3626ea8fb 100644 (file)
--- a/src/backend/executor/nodeSeqscan.c
+++ b/src/backend/executor/nodeSeqscan.c
@@ -66,8 +66,8 @@ SeqNext(SeqScanState *node)
        if (scandesc == NULL)
        {
                /*
-                * We reach here if the scan is not parallel, or if we're executing a
-                * scan that was intended to be parallel serially.
+                * We reach here if the scan is not parallel, or if we're serially
+                * executing a scan that was planned to be parallel.
                 */
                scandesc = heap_beginscan(node->ss.ss_currentRelation,
                                                                  estate->es_snapshot,