]> granicus.if.org Git - php/commitdiff
- Removed unnecessary check and allocation
authorFelipe Pena <felipensp@gmail.com>
Tue, 19 Nov 2013 22:13:51 +0000 (20:13 -0200)
committerFelipe Pena <felipensp@gmail.com>
Tue, 19 Nov 2013 22:13:51 +0000 (20:13 -0200)
phpdbg_cmd.c

index db7774d7e001df536808db6ad80079425e9398c5..d1767b00fb35da6c307636050c7dfad0b9b69b07 100644 (file)
@@ -247,29 +247,23 @@ phpdbg_input_t *phpdbg_read_input(TSRMLS_D) /* {{{ */
 
                buffer->string = phpdbg_trim(cmd, strlen(cmd), &buffer->length);
 
-               if (buffer->string) {
-                       /* temporary, when we switch to argv/argc handling
-                               will be unnecessary */
-                       char *store = (char*) estrdup(buffer->string);
+               /* store constant pointer to start of buffer */
+               buffer->start = (char* const*) buffer->string;
 
-                       /* store constant pointer to start of buffer */
-                       buffer->start = (char* const*) buffer->string;
+               buffer->argv = phpdbg_read_argv(
+                       buffer->string, &buffer->argc TSRMLS_CC);
 
-                       buffer->argv = phpdbg_read_argv(
-                               store, &buffer->argc TSRMLS_CC);
+#ifdef PHPDBG_DEBUG
+               if (buffer->argc) {
+                       int arg = 0;
 
-                       if (buffer->argc) {
-                               int arg = 0;
-
-                               while (arg < buffer->argc) {
-                                       phpdbg_debug(
-                                               "argv %d=%s", arg, buffer->argv[arg]->string);
-                                       arg++;
-                               }
+                       while (arg < buffer->argc) {
+                               phpdbg_debug(
+                                       "argv %d=%s", arg, buffer->argv[arg]->string);
+                               arg++;
                        }
-
-                       efree(store);
                }
+#endif
 
 #ifdef HAVE_LIBREADLINE
                if (cmd) {