]> granicus.if.org Git - taglib/commitdiff
Simpler conversion from bits to bytes.
authorTsuda Kageyu <tsuda.kageyu@gmail.com>
Thu, 3 Dec 2015 03:34:54 +0000 (12:34 +0900)
committerTsuda Kageyu <tsuda.kageyu@gmail.com>
Thu, 3 Dec 2015 03:34:54 +0000 (12:34 +0900)
taglib/mpeg/id3v2/frames/relativevolumeframe.cpp

index 44033cbcdb127f790146012fbe1eec9acdad3f64..a907f6b974bb9705eb6bc8cad81072384c9be27b 100644 (file)
 using namespace TagLib;
 using namespace ID3v2;
 
-static inline int bitsToBytes(int i)
-{
-  return i % 8 == 0 ? i / 8 : (i - i % 8) / 8 + 1;
-}
-
 struct ChannelData
 {
   ChannelData() : channelType(RelativeVolumeFrame::Other), volumeAdjustment(0) {}
@@ -185,7 +180,6 @@ void RelativeVolumeFrame::parseFields(const ByteVector &data)
 
   while(pos <= (int)data.size() - 4) {
 
-
     ChannelType type = ChannelType(data[pos]);
     pos += 1;
 
@@ -197,7 +191,7 @@ void RelativeVolumeFrame::parseFields(const ByteVector &data)
     channel.peakVolume.bitsRepresentingPeak = data[pos];
     pos += 1;
 
-    int bytes = bitsToBytes(channel.peakVolume.bitsRepresentingPeak);
+    const int bytes = (channel.peakVolume.bitsRepresentingPeak + 7) / 8;
     channel.peakVolume.peakVolume = data.mid(pos, bytes);
     pos += bytes;
   }