]> granicus.if.org Git - clang/commitdiff
Fix inaccurate comment about -fdelayed-template-parsing and MSVC
authorReid Kleckner <rnk@google.com>
Mon, 28 Aug 2017 17:59:24 +0000 (17:59 +0000)
committerReid Kleckner <rnk@google.com>
Mon, 28 Aug 2017 17:59:24 +0000 (17:59 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@311899 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Driver/ToolChains/Clang.cpp

index 47b9256f6c411203cdfb32607260222f9f8963ec..bc7f30eaa134ee2246fcbae19c2b00e2397deeed 100644 (file)
@@ -3846,8 +3846,10 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
                     !IsWindowsMSVC || IsMSVC2015Compatible))
     CmdArgs.push_back("-fno-threadsafe-statics");
 
-  // -fno-delayed-template-parsing is default, except for Windows where MSVC STL
-  // needs it.
+  // -fno-delayed-template-parsing is default, except when targetting MSVC.
+  // Many old Windows SDK versions require this to parse.
+  // FIXME: MSVC introduced /Zc:twoPhase- to disable this behavior in their
+  // compiler. We should be able to disable this by default at some point.
   if (Args.hasFlag(options::OPT_fdelayed_template_parsing,
                    options::OPT_fno_delayed_template_parsing, IsWindowsMSVC))
     CmdArgs.push_back("-fdelayed-template-parsing");