]> granicus.if.org Git - icu/commitdiff
ICU-13569 Add clarifying comment to some RBBI state table handling code.
authorAndy Heninger <andy.heninger@gmail.com>
Sat, 17 Feb 2018 22:29:07 +0000 (22:29 +0000)
committerAndy Heninger <andy.heninger@gmail.com>
Sat, 17 Feb 2018 22:29:07 +0000 (22:29 +0000)
X-SVN-Rev: 40948

icu4j/main/classes/core/src/com/ibm/icu/text/RBBITableBuilder.java

index 44b5e1a05fd835ebc28966923e367f5cf125f521..8954b672bbbc0b45ae9753eaedafc0487e40f4e8 100644 (file)
@@ -1054,7 +1054,10 @@ class RBBITableBuilder {
 
            //
            // Fill in the header fields.
-           //      Annoying because they really want to be ints, not shorts.
+           //      Note that NUMSTATES, ROWLEN and FLAGS are ints, not shorts.
+           //      ICU data created from Java is always big endian format, so
+           //      order the halves of the 32 bit fields into the short[] data accordingly.
+           //      TODO: ticket 13598 restructure so that ints are represented as ints directly.
            //
            // RBBIStateTable.fNumStates
            table[RBBIDataWrapper.NUMSTATES]   = (short)(numStates >>> 16);