fixed a potential (unlikely) 1 byte buffer overflow in strncat()

diff --git a/doc/en/changes.sgml b/doc/en/changes.sgml
index a734416e4e0eb135c0e3ccbe7f876bcbcb65af4f..8a3a74e628c036e4935efcaffb3d5bdc8f2d9c5c 100644 (file)
--- a/doc/en/changes.sgml
+++ b/doc/en/changes.sgml
@@ -14,14 +14,41 @@ A copy of the license is included in gfdl.sgml.
 
       <itemizedlist>
         <title>From version 3.0.6 to 3.1.0</title>
+         <listitem>
+            <para>Vixie cron compatibility: added options @reboot, @daily, @hourly, etc. Also added more generic options runatreboot, rebootreset and runonce.</para>
+         </listitem>
+        <listitem>
+           <para>Pass fcrondyn client credentials through the socket when possible so as the user doesn't need to type his password when using fcrondyn.</para>
+         </listitem>
          <listitem>
             <para>added audit (libaudit) support</para>
          </listitem>
         <listitem>
            <para>Better validation of string arguments of fcrontab options. In particular for timezones, previously a space could be added at the beginning or the end of the timezone with no warning, and this led fcron to use an unexpected timezone, which could cause confusion.</para>
          </listitem>
-        <listitem>
-           <para>Pass fcrondyn client credentials through the socket when possible so as the user doesn't need to type his password when using fcrondyn.</para>
+         <listitem>
+            <para>Allow tasks to run every seconds</para>
+         </listitem>
+         <listitem>
+            <para>fcron now sets the email headers X-Cron-Env and Auto-Submitted (as described in RFC 3834).</para>
+         </listitem>
+         <listitem>
+            <para>email encoding: fcron now sets the email headers Content-Type and Content-Transfer-Encoding. They can be controlled by setting the CONTENT_TYPE and CONTENT_TRANSFER_ENCODING variables in fcrontabs.</para>
+         </listitem>
+         <listitem>
+            <para>Added systemd service definition (thank you Reiner)</para>
+         </listitem>
+         <listitem>
+            <para>bug fix: fcrontab: don't alert about invalid character when correcting fcrontab twice</para>
+         </listitem>
+         <listitem>
+            <para>bug fix: fixed free_safe() function (replaced by macro).</para>
+         </listitem>
+         <listitem>
+            <para>bug fix: configure script: usage of sendmail couldn't be disabled</para>
+         </listitem>
+         <listitem>
+            <para>bug fix: fixed a potential (unlikely) 1 byte overflow in strncat() in socket.c</para>
          </listitem>
         <listitem>
            <para>Quite a lot of code clean-up and refactoring -- e.g. implemented generic unordred list for lavgq / exeq.</para>

diff --git a/doc/en/todo.sgml b/doc/en/todo.sgml
index b5dfa77df7f10e80f5e975673611a89c7050c943..5f0158769f6c8e416416b1eb318c7b746b267a49 100644 (file)
--- a/doc/en/todo.sgml
+++ b/doc/en/todo.sgml
@@ -23,12 +23,6 @@ A copy of the license is included in gfdl.sgml.
       <sect2>
         <title>High priority</title>
         <itemizedlist>
-           <listitem>
-              <para>@reboot: test updated startup script with removal of fcron.reboot + add to other scripts?</para>
-           </listitem>
-           <listitem>
-              <para>add audit (libaudit) + TEST</para>
-           </listitem>
         </itemizedlist>
       </sect2>
       <sect2>
@@ -66,10 +60,7 @@ A copy of the license is included in gfdl.sgml.
                  (file/line lists, serial queue, lavg list, exe list),
                  and work with them only through functions/macros.
               + secure equivalent to str[n]{cat|copy|...}</para>
-              <para>Note: may introduce bugs, so it will be done in fcron 3.1.x, and needs to be tested thoroughly..</para>
-           </listitem>
-           <listitem>
-              <para>Mem footprint reduction: use an/some union(s) in CL struct.</para>
+              <para>Note: may introduce bugs, so it will be done in fcron 3.1.x, and needs to be tested thoroughly.</para>
            </listitem>
            <listitem>
               <para>For environment settings, make a var substitution.</para>

diff --git a/socket.c b/socket.c
index 9eb62a42210c3e3f0447378e813997a9968888c2..dec56d487c41fbc73e4497733a63541a0e1c00f3 100644 (file)
--- a/socket.c
+++ b/socket.c
@@ -372,7 +372,7 @@ auth_client_password(struct fcrondyn_cl *client)
         len += (sizeof(FIELD_STR)-1); \
     }
 #define Add_field(FIELD_STR) \
-    strncat(fields, FIELD_STR, sizeof(fields) - len); \
+    strncat(fields, FIELD_STR, sizeof(fields) - len - 1); \
     len += (sizeof(FIELD_STR)-1);
 
 void